This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Correct the return type of simulateTransaction when accounts are not loaded
#2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5bb7d21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveluscher
referenced
this pull request
Jun 27, 2024
* refactor(experimental): add simulateTransaction RPC call * Change @default to @DefaultValue See https://typedoc.org/tags/defaultValue/
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
force-pushed
the
06-27-correct_the_return_type_of_simulatetransaction_when_accounts_are_not_loaded
branch
from
f1baa9e to
5bb7d21
Compare
This was referenced Jun 27, 2024
buffalojoec
approved these changes
Jun 28, 2024
| @@ -127,7 +127,7 @@ export interface SimulateTransactionApi extends RpcApiMethods { | |||
| simulateTransaction( | |||
| base58EncodedWireTransaction: Base58EncodedBytes, | |||
| config?: SigVerifyAndReplaceRecentBlockhashConfig & SimulateTransactionConfigBase, | |||
| ): SimulateTransactionApiResponseBase & { accounts: null }; | |||
| ): SimulateTransactionApiResponseBase & SolanaRpcResponse<{ readonly accounts: null }>; | |||
There was a problem hiding this comment.
I think this points out a broader issue.
In lots of places, we're including the RpcResponse wrapper in the "base response", but in others, we do something like:
RpcResponse<Base & { ... }>
I think it should always be the latter. I'll make a note to comb for this in my pass over RPC stuff.
steveluscher
deleted the
06-27-correct_the_return_type_of_simulatetransaction_when_accounts_are_not_loaded
branch
|
🎉 This PR is included in version 1.93.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was returning
accounts: nullat the top level instead of insidevalueSee 7192f3d