Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Freeze instructions and lifetime in transaction message objects #2607

Merged
merged 6 commits into from
May 5, 2024

Conversation

mcintyre94
Copy link
Contributor

@mcintyre94 mcintyre94 commented May 3, 2024

  • Freeze the instructions array when we append/prepend instructions
  • Freeze the instructions array when we create a transaction message
  • Freeze the instructions array and lifetime when adding a durable nonce
  • Freeze the lifetime constraint when adding a blockhash
  • Freeze instructions when decompiling a transaction message

Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: a38f2a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@solana/transaction-messages Patch
@solana/web3.js-experimental Patch
@solana/programs Patch
@solana/rpc-api Patch
@solana/rpc-subscriptions-api Patch
@solana/signers Patch
@solana/transaction-confirmation Patch
@solana/transactions Patch
@solana/rpc Patch
@solana/sysvars Patch
@solana/rpc-subscriptions Patch
@solana/compat Patch
@solana/rpc-graphql Patch
@solana/accounts Patch
@solana/addresses Patch
@solana/assertions Patch
@solana/codecs-core Patch
@solana/codecs-data-structures Patch
@solana/codecs-numbers Patch
@solana/codecs-strings Patch
@solana/codecs Patch
@solana/errors Patch
@solana/fast-stable-stringify Patch
@solana/functional Patch
@solana/instructions Patch
@solana/keys Patch
@solana/options Patch
@solana/rpc-parsed-types Patch
@solana/rpc-spec-types Patch
@solana/rpc-spec Patch
@solana/rpc-subscriptions-spec Patch
@solana/rpc-subscriptions-transport-websocket Patch
@solana/rpc-transformers Patch
@solana/rpc-transport-http Patch
@solana/rpc-types Patch
@solana/webcrypto-ed25519-polyfill Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mcintyre94 and the rest of your teammates on Graphite Graphite

@mcintyre94 mcintyre94 changed the title freeze the instructions array when we append/prepend instructions Deep freeze transaction message objects May 3, 2024
@mcintyre94 mcintyre94 changed the title Deep freeze transaction message objects Freeze instructions and lifetime in transaction message objects May 3, 2024
@mcintyre94 mcintyre94 marked this pull request as ready for review May 3, 2024 10:57
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@mcintyre94 mcintyre94 force-pushed the freeze-instructions branch from 0ec725c to a38f2a2 Compare May 4, 2024 16:30
@mcintyre94 mcintyre94 merged commit 3d90241 into master May 5, 2024
8 checks passed
@mcintyre94 mcintyre94 deleted the freeze-instructions branch May 5, 2024 15:32
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[experimental] Freeze instructions array in transaction message mutators
3 participants