Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(experimental): graphql: token-2022 extensions: withdrawWithheldTokensFromMint #2579

Merged
merged 4 commits into from
May 4, 2024
Merged

refactor(experimental): graphql: token-2022 extensions: withdrawWithheldTokensFromMint #2579

merged 4 commits into from
May 4, 2024

Conversation

Hrushi20
Copy link
Contributor

This PR adds support for Token-2022's TransferFeeExtension's withdrawWithheldTokensFromMint instruction
in the GraphQL schema.

Continuing work on #2406.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c612d56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Apr 28, 2024
@mergify mergify bot requested a review from a team April 28, 2024 08:14
buffalojoec
buffalojoec reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thanks for the continued effort!

packages/rpc-graphql/src/__tests__/transaction-tests.ts Outdated Show resolved Hide resolved
packages/rpc-graphql/src/schema/instruction.ts Show resolved Hide resolved
@buffalojoec buffalojoec mentioned this pull request Apr 30, 2024
Merged
buffalojoec
buffalojoec approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wohoo

packages/rpc-graphql/src/__tests__/transaction-tests.ts Outdated Show resolved Hide resolved
@buffalojoec buffalojoec changed the title #2406: graphql: token-2022 extensions: withdrawWithheldTokensFromMint refactor(experimental): graphql: token-2022 extensions: withdrawWithheldTokensFromMint May 2, 2024
@Hrushi20 Hrushi20 force-pushed the feature-withdrawWithheldTokensFromMint branch from 52df0af to 73cfd29 Compare May 3, 2024 02:15
@Hrushi20 Hrushi20 force-pushed the feature-withdrawWithheldTokensFromMint branch from 73cfd29 to c612d56 Compare May 4, 2024 03:06
@Hrushi20
Copy link
Contributor Author

Hrushi20 commented May 4, 2024

This PR can be merged.

@buffalojoec buffalojoec merged commit 870bd1d into solana-labs:master May 4, 2024
6 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hrushi20 @buffalojoec