Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: token-2022 extensions: InitializeTransferFeeConfig #2575

Merged

Conversation

Hrushi20
Copy link
Contributor

This PR adds support for Token-2022's TransferFeeExtension's InitializeTransferFeeConfig instruction
in the GraphQL schema.

Todo:
Need to add test.

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: 88a878c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Apr 26, 2024
@mergify mergify bot requested a review from a team April 26, 2024 18:16
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Tests shouldn't be too bad to add. I made a section for Token-2022 extensions so you don't have to mess with Jest.

describe('token-2022 extensions', () => {

Feel free to check this one off the issue once it's merged!

packages/rpc-graphql/src/__tests__/__setup__.ts Outdated Show resolved Hide resolved
@Hrushi20 Hrushi20 marked this pull request as ready for review April 26, 2024 23:12
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

super

@buffalojoec buffalojoec merged commit 7151be6 into solana-labs:master Apr 27, 2024
6 checks passed
@Hrushi20 Hrushi20 deleted the feature-initializeTransferFeeConfig branch April 27, 2024 17:23
Copy link
Contributor

github-actions bot commented May 3, 2024

🎉 This PR is included in version 1.91.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants