Split the dependency between `compile:typedefs` and the legacy library #2370

steveluscher · 2024-03-22T23:51:35Z

No description provided.

changeset-bot · 2024-03-22T23:51:40Z

⚠️ No Changeset found

Latest commit: 8b283f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

steveluscher · 2024-03-22T23:51:43Z

Split the dependency between compile:typedefs and the legacy library #2370 👈
Find all misnamed Rollup configs and fix them #2371 : 1 other dependent PR (#2372 )
Bust the prettier cache any time any file changes #2369
Strip outputs from the Turborepo config, because omitting it is the same as passing an empty array #2368
Break the style:fix cache any time any file changes #2367
Since tests depend on _implementations_, make sure to build upstreams before running tests #2373 : 1 other dependent PR (#2374 )
Move dependencies out of devDependencies where they are used in the implementation #2375
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

steveluscher · 2024-03-22T23:53:14Z

turbo.json

+            "outputs": ["docs/**", "declarations/**", "lib/**"]
+        },
+        "@solana/web3.js#clean": {
+            "outputs": ["doc/**", "declarations/**", "lib/**"]


Also bunch missing from clean.

steveluscher · 2024-03-22T23:58:53Z

turbo.json

+        },
+        "@solana/web3.js#compile:js": {
+            "dependsOn": ["clean", "^compile:js"],
+            "inputs": ["babel.config.json", "rollup.config.mjs", "tsconfig.*", "src/**"],


Babel config was missing.

steveluscher · 2024-03-22T23:59:14Z

turbo.json

+                "rollup.config.types.mjs",
+                "scripts/typegen.sh",
+                "src/**",
+                "test/__shadow-jest-types.d.ts",
+                "tsconfig.*"


Lots of stuff used in scripts/typegen.sh that was missing.

steveluscher · 2024-03-23T00:00:44Z

turbo.json

        "@solana/web3.js#test:unit:node": {
-            "dependsOn": ["compile:js"],
-            "inputs": ["babel.config.json", "src/**", "test/**"]


Tests use ts-mocha so they don't actually depend on Babel.

steveluscher · 2024-03-23T00:02:28Z

turbo.json

+                "test:typecheck",
+                "test:unit:node"
+            ],
+            "outputs": ["doc/**", "declarations/**", "lib/**"]


Bunch of outputs missing previously.

steveluscher · 2024-03-23T01:30:24Z

Merge activity

Mar 22, 6:30 PM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
Mar 22, 6:42 PM PDT: Graphite rebased this pull request as part of a merge.
Mar 22, 6:43 PM PDT: @steveluscher merged this pull request with Graphite.

github-actions · 2024-03-26T19:55:49Z

🎉 This PR is included in version 1.91.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions · 2024-04-11T08:04:04Z

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

This was referenced Mar 22, 2024

Break the style:fix cache any time any file changes #2367

Merged

Strip outputs from the Turborepo config, because omitting it is the same as passing an empty array #2368

Merged

steveluscher mentioned this pull request Mar 22, 2024

Bust the prettier cache any time any file changes #2369

Merged

steveluscher changed the base branch from 03-22-bust_the_prettier_cache_any_time_any_file_changes to 03-22-find_all_misnamed_rollup_configs_and_fix_them March 22, 2024 23:57

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from c048ca1 to 89625d3 Compare March 22, 2024 23:57

steveluscher mentioned this pull request Mar 22, 2024

Find all misnamed Rollup configs and fix them #2371

Merged

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch 2 times, most recently from e08ba97 to 5ffe87b Compare March 23, 2024 00:01

steveluscher commented Mar 23, 2024

View reviewed changes

steveluscher changed the base branch from 03-22-find_all_misnamed_rollup_configs_and_fix_them to 03-23-ensure_that_any_package_that_inlines_another_package_builds_that_package_first March 23, 2024 00:19

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from 5ffe87b to 32ccc43 Compare March 23, 2024 00:19

steveluscher mentioned this pull request Mar 23, 2024

Ensure that any package that inlines another package builds that package first #2372

Closed

steveluscher force-pushed the 03-23-ensure_that_any_package_that_inlines_another_package_builds_that_package_first branch from c0ce53d to a32c78d Compare March 23, 2024 00:33

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from 32ccc43 to 3127bf6 Compare March 23, 2024 00:33

steveluscher mentioned this pull request Mar 23, 2024

Since tests depend on _implementations_, make sure to build upstreams before running tests #2373

Merged

steveluscher force-pushed the 03-23-ensure_that_any_package_that_inlines_another_package_builds_that_package_first branch from a32c78d to 3f9f5b4 Compare March 23, 2024 00:43

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from 3127bf6 to 72ec318 Compare March 23, 2024 00:43

steveluscher mentioned this pull request Mar 23, 2024

Because libraries inline all of their code into iife bundles, they must build their upstreams first. #2374

Closed

steveluscher changed the base branch from 03-23-ensure_that_any_package_that_inlines_another_package_builds_that_package_first to 03-22-find_all_misnamed_rollup_configs_and_fix_them March 23, 2024 01:17

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from 72ec318 to fb7bcbd Compare March 23, 2024 01:17

steveluscher closed this Mar 23, 2024

steveluscher reopened this Mar 23, 2024

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from fb7bcbd to dc74e1f Compare March 23, 2024 01:23

steveluscher force-pushed the 03-22-find_all_misnamed_rollup_configs_and_fix_them branch from 76fc9b4 to 3233dbb Compare March 23, 2024 01:40

Base automatically changed from 03-22-find_all_misnamed_rollup_configs_and_fix_them to master March 23, 2024 01:41

steveluscher added 2 commits March 23, 2024 01:42

Split the dependency between compile:typedefs and the legacy library

b832b26

Separate the legacy library Turbo steps from the rest

8b283f8

steveluscher force-pushed the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch from dc74e1f to 8b283f8 Compare March 23, 2024 01:42

steveluscher merged commit 6135928 into master Mar 23, 2024
6 checks passed

steveluscher deleted the 03-22-split_the_dependency_between_compile_typedefs_and_the_legacy_library branch March 23, 2024 01:43

github-actions bot added the released label Mar 26, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split the dependency between `compile:typedefs` and the legacy library #2370

Split the dependency between `compile:typedefs` and the legacy library #2370

steveluscher commented Mar 22, 2024

changeset-bot bot commented Mar 22, 2024 •

edited

Loading

steveluscher commented Mar 22, 2024 •

edited

Loading

steveluscher Mar 22, 2024

steveluscher Mar 22, 2024

steveluscher Mar 22, 2024

steveluscher Mar 23, 2024

steveluscher Mar 23, 2024

steveluscher commented Mar 23, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024

github-actions bot commented Apr 11, 2024

Split the dependency between compile:typedefs and the legacy library #2370

Split the dependency between compile:typedefs and the legacy library #2370

Conversation

steveluscher commented Mar 22, 2024

changeset-bot bot commented Mar 22, 2024 • edited Loading

⚠️ No Changeset found

steveluscher commented Mar 22, 2024 • edited Loading

steveluscher Mar 22, 2024

Choose a reason for hiding this comment

steveluscher Mar 22, 2024

Choose a reason for hiding this comment

steveluscher Mar 22, 2024

Choose a reason for hiding this comment

steveluscher Mar 23, 2024

Choose a reason for hiding this comment

steveluscher Mar 23, 2024

Choose a reason for hiding this comment

steveluscher commented Mar 23, 2024 • edited Loading

Merge activity

github-actions bot commented Mar 26, 2024

github-actions bot commented Apr 11, 2024

Split the dependency between `compile:typedefs` and the legacy library #2370

Split the dependency between `compile:typedefs` and the legacy library #2370

changeset-bot bot commented Mar 22, 2024 •

edited

Loading

steveluscher commented Mar 22, 2024 •

edited

Loading

steveluscher commented Mar 23, 2024 •

edited

Loading