Skip to content

Commit

Permalink
Inlined dependencies must live in devDependencies so that they don'…
Browse files Browse the repository at this point in the history
…t appear as dependencies in the published package (#3676)
  • Loading branch information
steveluscher authored Dec 5, 2024
1 parent c880687 commit 6ae441e
Show file tree
Hide file tree
Showing 7 changed files with 37 additions and 28 deletions.
2 changes: 1 addition & 1 deletion packages/rpc-subscriptions-channel-websocket/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@
],
"dependencies": {
"@solana/errors": "workspace:*",
"@solana/event-target-impl": "workspace:*",
"@solana/functional": "workspace:*",
"@solana/rpc-subscriptions-spec": "workspace:*",
"@solana/subscribable": "workspace:*"
},
"devDependencies": {
"@solana/event-target-impl": "workspace:*",
"@solana/ws-impl": "workspace:*",
"jest-websocket-mock": "^2.5.0"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/rpc-subscriptions-spec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@
],
"dependencies": {
"@solana/errors": "workspace:*",
"@solana/event-target-impl": "workspace:*",
"@solana/promises": "workspace:*",
"@solana/rpc-spec-types": "workspace:*",
"@solana/subscribable": "workspace:*"
},
"devDependencies": {
"@solana/event-target-impl": "workspace:*"
},
"peerDependencies": {
"typescript": ">=5"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/rpc-subscriptions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
],
"dependencies": {
"@solana/errors": "workspace:*",
"@solana/event-target-impl": "workspace:*",
"@solana/fast-stable-stringify": "workspace:*",
"@solana/functional": "workspace:*",
"@solana/promises": "workspace:*",
Expand All @@ -85,7 +84,8 @@
"@solana/subscribable": "workspace:*"
},
"devDependencies": {
"@solana/addresses": "workspace:*"
"@solana/addresses": "workspace:*",
"@solana/event-target-impl": "workspace:*"
},
"peerDependencies": {
"typescript": ">=5"
Expand Down
4 changes: 3 additions & 1 deletion packages/rpc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
],
"dependencies": {
"@solana/errors": "workspace:*",
"@solana/event-target-impl": "workspace:*",
"@solana/fast-stable-stringify": "workspace:*",
"@solana/functional": "workspace:*",
"@solana/rpc-api": "workspace:*",
Expand All @@ -82,6 +81,9 @@
"@solana/rpc-transport-http": "workspace:*",
"@solana/rpc-types": "workspace:*"
},
"devDependencies": {
"@solana/event-target-impl": "workspace:*"
},
"peerDependencies": {
"typescript": ">=5"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/subscribable/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@
"maintained node versions"
],
"dependencies": {
"@solana/errors": "workspace:*",
"@solana/errors": "workspace:*"
},
"devDependencies": {
"@solana/event-target-impl": "workspace:*"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/transaction-confirmation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
"@solana/addresses": "workspace:*",
"@solana/codecs-strings": "workspace:*",
"@solana/errors": "workspace:*",
"@solana/event-target-impl": "workspace:*",
"@solana/keys": "workspace:*",
"@solana/promises": "workspace:*",
"@solana/rpc": "workspace:*",
Expand All @@ -84,6 +83,7 @@
},
"devDependencies": {
"@solana/codecs-core": "workspace:*",
"@solana/event-target-impl": "workspace:*",
"@solana/instructions": "workspace:*"
},
"peerDependencies": {
Expand Down
45 changes: 24 additions & 21 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6ae441e

Please sign in to comment.