math: more type tests #6713
Merged
math: more type tests #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
May 13, 2024
| let (mut banks_client, payer, recent_blockhash) = pc.start().await; | ||
|
|
||
| let mut transaction = Transaction::new_with_payer( | ||
| &[instruction::u128_divide(u128::MAX, u128::MAX / 69)], |
| let (mut banks_client, payer, recent_blockhash) = pc.start().await; | ||
|
|
||
| let mut transaction = Transaction::new_with_payer( | ||
| &[instruction::f64_divide(f64::powf(2., 42.), 420420.6969)], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the following command has been helpful determining which types to use for various math operations:
In considering how to perform math in our programs (whether to create methods to replicate performing floating-point arithmetic or to use floats directly), we needed to benchmark some arithmetic with u128 vs f64.
This PR adds multiplication and division for each of these types.