Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to solana 1.17.17 #6189

Merged

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Jan 27, 2024

  • Upgrade solana version to 1.17.17
  • Added missing display logic for the new group extensions in the token-cli

@samkim-crypto samkim-crypto added the WIP Work in progress label Jan 27, 2024
@samkim-crypto samkim-crypto force-pushed the upgrade-solana-1.17.17 branch 2 times, most recently from 3e678a2 to e480899 Compare January 31, 2024 02:18
@samkim-crypto samkim-crypto removed the WIP Work in progress label Jan 31, 2024
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one question on the Rust version

@@ -1,2 +1,2 @@
[toolchain]
channel = "1.73.0"
channel = "1.75.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but Solana v1.17 is still on Rust 1.73, so we should stay on Rust 1.73, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes you are completely right! I removed the commit.

@samkim-crypto samkim-crypto force-pushed the upgrade-solana-1.17.17 branch from e480899 to 4027950 Compare February 1, 2024 00:15
@samkim-crypto samkim-crypto force-pushed the upgrade-solana-1.17.17 branch from 4027950 to e4d9551 Compare February 1, 2024 00:20
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks!

@samkim-crypto samkim-crypto merged commit b7bf16f into solana-labs:master Feb 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants