-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to solana 1.17.17 #6189
Upgrade to solana 1.17.17 #6189
Conversation
samkim-crypto
commented
Jan 27, 2024
•
edited by joncinque
Loading
edited by joncinque
- Upgrade solana version to 1.17.17
- Added missing display logic for the new group extensions in the token-cli
3e678a2
to
e480899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the one question on the Rust version
rust-toolchain.toml
Outdated
@@ -1,2 +1,2 @@ | |||
[toolchain] | |||
channel = "1.73.0" | |||
channel = "1.75.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but Solana v1.17 is still on Rust 1.73, so we should stay on Rust 1.73, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes you are completely right! I removed the commit.
e480899
to
4027950
Compare
4027950
to
e4d9551
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect, thanks!