-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play Client Interpreter #791
Conversation
e2403fa
to
9c000f9
Compare
2263992
to
c96ed9b
Compare
74f63bc
to
569f338
Compare
Supports only AkkaStreams as Streaming, does not support Multipart
569f338
to
cc45031
Compare
cc45031
to
3d8ce21
Compare
|
||
Example: | ||
|
||
```scala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try adding scala mdoc:compile-only
to that this example is compiled (when running mdoc
in the documentation project)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm not familiar with mdoc
but it's an opportunity to see how it works :)
I'll do it in another PR as I see you've already merged this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixe dthis already :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great thanks :)
Thanks, looks really solid! I suppose the multipart tests need to be disabled? Otherwise it's good to merge :) |
Ah they are disabled 🤦 nevermind ;) |
Merging then :) |
Thanks for the quick review 👍 |
@adamw Not sure, but I might have broke the documentation for the clients. I don't see the links to the clients pages at https://tapir.softwaremill.com/ (https://tapir.softwaremill.com/en/latest/sttp.html still accessible though). |
@gaeljw Fixed, two of the generated doc files where missing |
Released in https://github.com/softwaremill/tapir/releases/tag/v0.17.0-M7, thanks! |
This PR aims to solve #738.
Things to note from a user perspective:
AkkaStreams
capabilityThings to note for the review:
All feedbacks are welcomed :)