Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play Client Interpreter #791

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Play Client Interpreter #791

merged 2 commits into from
Nov 2, 2020

Conversation

gaeljw
Copy link
Contributor

@gaeljw gaeljw commented Oct 10, 2020

This PR aims to solve #738.

Things to note from a user perspective:

Things to note for the review:

  • I had to slighty change some tests that were relying on the output order of header values because Play client doesn't preserve the order (I didn't ready the HTTP spec but I don't think this is a requirement)
  • I moved the multipart tests to a separate class so that sttp-client can implement them but not necessarily play-client
  • I moved the documentation for clients in a sub directory

All feedbacks are welcomed :)

@gaeljw gaeljw force-pushed the play-ws-client branch 2 times, most recently from 2263992 to c96ed9b Compare November 1, 2020 13:18
@gaeljw gaeljw marked this pull request as ready for review November 1, 2020 15:16
@gaeljw gaeljw changed the title (WIP) Play Client Interpreter Play Client Interpreter Nov 1, 2020
Supports only AkkaStreams as Streaming, does not support Multipart

Example:

```scala
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try adding scala mdoc:compile-only to that this example is compiled (when running mdoc in the documentation project)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm not familiar with mdoc but it's an opportunity to see how it works :)

I'll do it in another PR as I see you've already merged this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixe dthis already :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great thanks :)

@adamw
Copy link
Member

adamw commented Nov 2, 2020

Thanks, looks really solid!

I suppose the multipart tests need to be disabled? Otherwise it's good to merge :)

@adamw
Copy link
Member

adamw commented Nov 2, 2020

Ah they are disabled 🤦 nevermind ;)

@adamw
Copy link
Member

adamw commented Nov 2, 2020

Merging then :)

@adamw adamw merged commit 6826ffc into softwaremill:master Nov 2, 2020
@gaeljw
Copy link
Contributor Author

gaeljw commented Nov 2, 2020

Thanks for the quick review 👍

@gaeljw gaeljw deleted the play-ws-client branch November 2, 2020 12:17
@gaeljw
Copy link
Contributor Author

gaeljw commented Nov 2, 2020

@adamw Not sure, but I might have broke the documentation for the clients. I don't see the links to the clients pages at https://tapir.softwaremill.com/ (https://tapir.softwaremill.com/en/latest/sttp.html still accessible though).

@adamw
Copy link
Member

adamw commented Nov 2, 2020

@gaeljw Fixed, two of the generated doc files where missing

@adamw
Copy link
Member

adamw commented Nov 2, 2020

Released in https://github.com/softwaremill/tapir/releases/tag/v0.17.0-M7, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants