-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support in Pekko interpreter for status codes >=600 #4322
Add support in Pekko interpreter for status codes >=600 #4322
Conversation
//> using dep com.softwaremill.sttp.tapir::tapir-core:1.11.13 | ||
//> using dep com.softwaremill.sttp.tapir::tapir-pekko-http-server:1.11.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously not correct, but I don't know which version to use in an example for a feature that has not been released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately examples of new features have to be commented out until there's a release
As I understand you need to call the |
c70ed7f
to
6735172
Compare
For my use case it will be enough. I haven't checked the Pekko HTTP internals very carefully, but judging from a glance parameters like |
Maybe add a test? :) |
|
Thanks :) |
Pekko supports registering custom status codes with values >=600. Currently, if an endpoint returns such a status code, the Pekko interpreter will crash due to the call to the two argument version of
StatusCodes.custom
. This PRadds possibility of registering Pekko custom status codes usingfixes that behavior by using the five parameter version of the method.PekkoHttpServerOptions