Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed NettyId to NettySync #3689

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Renamed NettyId to NettySync #3689

merged 1 commit into from
Apr 16, 2024

Conversation

Pask423
Copy link
Contributor

@Pask423 Pask423 commented Apr 16, 2024

closes #3625

@Pask423 Pask423 requested review from adamw and kciesielski April 16, 2024 10:50
@Pask423 Pask423 self-assigned this Apr 16, 2024
@adamw
Copy link
Member

adamw commented Apr 16, 2024

Thanks!

@kciesielski @lbialy what do you think, how should we call the synchronouse variants of tapir interpreters / sttp client backends? For reference:

  • they use the Id "effect" type
  • in sttp client, we currently have e.g. DefaultSyncBackend, HttpClientSyncBackend
  • for Futures, we have NettyFutureServer, HttpClientFutureBackend; for CE, NettyCatsServer, HttpClientCatsBackend
  • hence here propose also NettySyncServer
  • alternatively, we can go with simply NettyServer and HttpClientBackend

opinions? :)

@lbialy
Copy link
Contributor

lbialy commented Apr 16, 2024 via email

@kciesielski
Copy link
Member

+1 to @lbialy :)

@adamw
Copy link
Member

adamw commented Apr 16, 2024

Ok, thanks for your input :)

@adamw adamw merged commit e00bad2 into master Apr 16, 2024
28 checks passed
@adamw adamw deleted the issue-3625 branch April 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename NettyIdServer to NettySyncServer
4 participants