codegen: Remove dead comments #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
force-pushed
the
tests
branch
2 times, most recently
from
73cba8b to
18544bf
Compare
hughsimpson
changed the title
hughsimpson
changed the title
kciesielski
reviewed
Apr 9, 2024
...gin/src/sbt-test/sbt-openapi-codegen/oneOf-json-roundtrip_jsoniter/src/main/scala/Main.scala
Outdated
Show resolved
Hide resolved
openapi-codegen/sbt-plugin/src/sbt-test/sbt-openapi-codegen/minimal/build.sbt
Outdated
Show resolved
Hide resolved
|
Well looks like #3655 got merged ahead of this one 😅 but I'm leaving it open to remove those dead comments. |
hughsimpson
changed the title
|
I was supposed to merge this PR, not #3655, my bad! 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to address #841The goal here is to run some tests on the JSON serialisation and schema generation to ensure discriminator declarations or lack thereof are respected for various jsonLib+scala versions.Writing the tests for this revealed a difference in behaviour between jsoniter-scala and circe behaviour that I was unaware of (namely that jsoniter-scala will happily accept a json with a missing array field, treating it as an empty array; whereas circe will fail (the latter of which is what I'd expect given an openapi spec with 'required: true' stipulated on the given array field)). I've decided to try to keep this pr smaller than originally intended, and introduce only the new tests; although I have made a follow-up to address that specific issue.This pr does, however, fix the caching, which I apparently broke previously when permitting the output to range across multiple files (cachedCopyFilecheck needs to be given a different cacheFile for each input file). Honestly, I think this is sufficient justification on its own for inclusion of the new tests in CIEdit: was merged in #3655
Now just removes some dead comments