Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FailFast policy. #42

Merged
merged 2 commits into from
May 30, 2022
Merged

Add FailFast policy. #42

merged 2 commits into from
May 30, 2022

Conversation

AvaPL
Copy link
Contributor

@AvaPL AvaPL commented May 27, 2022

This policy reduces the boilerplate that is needed in cases where retry for some exceptions doesn't make sense. See: #33.

@adamw
Copy link
Member

adamw commented May 30, 2022

@AvaPL there seem to be some test failures & compile errors

@AvaPL
Copy link
Contributor Author

AvaPL commented May 30, 2022

Fixed, I forgot about cross compilation. The problem here was related to an issue in Scala 3.0.0 scala/scala3#12661, maybe version in this repo should be bumped.

@adamw
Copy link
Member

adamw commented May 30, 2022

@AvaPL ah, feel free to bump the scala version as needed

@AvaPL
Copy link
Contributor Author

AvaPL commented May 30, 2022

As I've already fixed the compilation, maybe let's leave it as it is. I don't think that changing the versions should be in scope of this PR.

@adamw adamw merged commit feae320 into softwaremill:master May 30, 2022
@adamw
Copy link
Member

adamw commented May 30, 2022

Released in 0.3.5, thanks :)

@AvaPL
Copy link
Contributor Author

AvaPL commented May 30, 2022

Thank you! #33 can also be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants