Changed exception when sending msg to queue without proper url #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Jun 1, 2021
| def requiredUrlParam(n: String): Directive1[String] = { | ||
| p.get(n) match { | ||
| case Some(v) => provide(v) | ||
| case None => reject(WrongURLFormatRejection(n)) |
There was a problem hiding this comment.
hm well if the parameter is absent, then the format isn't wrong, it's missing, no? :)
There was a problem hiding this comment.
Yes, changed back to MissingQueryParamRejection :)
There was a problem hiding this comment.
Yes, resulting exception is still the same.
There was a problem hiding this comment.
I mean, the method requiredUrlParam gives a WrongURLFormatRejection which is not very logical
There was a problem hiding this comment.
Modified solution, added new directive.
adamw
reviewed
Jun 18, 2021
| private def checkOnlyQueueNameInUri(): Directive1[String] = { | ||
| extractUri.flatMap { | ||
| uri => { | ||
| val onlyQueueNameInUriPath = Option(uri.path.toString().tail) |
There was a problem hiding this comment.
doesn't this always return Some(the uri without the first character)?
There was a problem hiding this comment.
Thanks for advice, now I'm checking if there is only one segment in uri.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.