feat: make svgView getter public
#2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew-getter-public
latekvo
added a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Feb 25, 2025
## Description <!-- Description and motivation for this PR. Include 'Fixes #<number>' if this is fixing some issue. --> This PR adds integration with the `react-native-svg` (`RNSVG`) to improve hitbox detection of the SVG elements they provide. ~~blocked~~ by software-mansion/react-native-svg#2583 ~~blocked~~ by `nested SvgViews with viewBox prop have invalid hit detection` - No issue opened yet ## Test plan <!-- Describe how did you test this change here. --> - use the newly added SVG integration example for testing this feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts #2555, as
RenderableView.hitTest()can be replaced bySvgView.reactTagForTouch(), which is alreadypublic.This PR also changes the
package-privategetSvgView()method ofVirtualViewtopublic.This change has been made to handle hit detection of transformed
VirtualViews, asRenderableView'shitTest()doesn't take transformations into account, whileSvgView'sreactTagForTouch()does.Making
getSvgView()public is necessary for integrating RNSVG support into RNGH. More details here.Test Plan
Run the example from the RNGH - RNSVG integration PR.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md__tests__folder