-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from android support v4 to androidX #68
Conversation
Hi @kmagiera I am just wondering if you have any date to merge this PR? |
Hey @bpeyrouBDHIS and @alanlima I'd like to consider this PR but not sure what kind of consequences it brings for end users. I see you update SDK version so I'm wondering how that'd work for people who are on SDK versions below 28 with their apps? Are we going to require them to upgrade their projects? What if they need to support older Android versions? What is the impact on the application footprint? |
@kmagiera AFAIK react-native v0.60 is gonna make the breaking change already so I suggest you to release it with a major version bump and a note in the readme ( RN < 0.6 use v1) |
Also see this discussion: react-native-community/discussions-and-proposals#129 This change is required to support RN 0.60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙌
Guys, 1.0.0-aplha23 is backward incompatible with RN < 0.60 because of this PR. You need to notify about it in README file. |
And what is much worse, react-navigation/native is unlocked to use any 1.0.0 version |
I am having the same issue! I had to install using I also had to do another hacky solution to fix this: @kmagiera Take a look at https://semver.org/ |
This is why jetifier exists. The migration to AndroidX is necessary to get to full support with RN0.60. However, if you want to stay on the support libraries the jetifier tool will make this possible via reverse-jetify. It is the tool recommended in the release notes of RN0.60 as well. |
This is for an AndroidX app to use not androidx libraries. It shouldn't work in the cases that our app is not androidx, but the library is androidx. |
I mentioned the reverse option which works fine for an app using support libraries that uses packages that are based on AndroidX. |
)" This reverts commit ed826d7. To keep 1.0 branch pre-androidx
This PR aims to upgrade from android support v4 to androidX.