Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from android support v4 to androidX #68

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

bpeyrouBDHIS
Copy link
Contributor

This PR aims to upgrade from android support v4 to androidX.

@alanlima
Copy link

Hi @kmagiera

I am just wondering if you have any date to merge this PR?

@kmagiera
Copy link
Member

Hey @bpeyrouBDHIS and @alanlima

I'd like to consider this PR but not sure what kind of consequences it brings for end users. I see you update SDK version so I'm wondering how that'd work for people who are on SDK versions below 28 with their apps? Are we going to require them to upgrade their projects? What if they need to support older Android versions? What is the impact on the application footprint?

@brunobar79
Copy link

@kmagiera AFAIK react-native v0.60 is gonna make the breaking change already so I suggest you to release it with a major version bump and a note in the readme ( RN < 0.6 use v1)

@se-bastiaan
Copy link

Also see this discussion: react-native-community/discussions-and-proposals#129

This change is required to support RN 0.60

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

@kmagiera kmagiera merged commit ed826d7 into software-mansion:master Jul 4, 2019
@radeno
Copy link

radeno commented Jul 8, 2019

Guys, 1.0.0-aplha23 is backward incompatible with RN < 0.60 because of this PR.

You need to notify about it in README file.

@radeno
Copy link

radeno commented Jul 8, 2019

And what is much worse, react-navigation/native is unlocked to use any 1.0.0 version
https://github.com/react-navigation/native/blob/d54c3590825a3567f63fdea940a784699c653742/package.json#L95
So after yarn upgrade, all users without RN 0.60 will be hit, and not able compile on Android.

@JustinKasad
Copy link

I am having the same issue!

I had to install using
yarn add https://github.com/kmagiera/react-native-screens#0627e742c8fd992148a17266dd39f8760142a16c to get everything to work on RN 58.

I also had to do another hacky solution to fix this:
#124

@kmagiera Take a look at https://semver.org/
Proper versioning would alleviate these kinds of issues.

@se-bastiaan
Copy link

se-bastiaan commented Jul 10, 2019

This is why jetifier exists. The migration to AndroidX is necessary to get to full support with RN0.60. However, if you want to stay on the support libraries the jetifier tool will make this possible via reverse-jetify. It is the tool recommended in the release notes of RN0.60 as well.

@cylim
Copy link

cylim commented Aug 20, 2019

This is why jetifier exists. The migration to AndroidX is necessary to get to full support with RN0.60. However, if you want to stay on the support libraries the jetifier tool will make this possible via reverse-jetify. It is the tool recommended in the release notes of RN0.60 as well.

This is for an AndroidX app to use not androidx libraries. It shouldn't work in the cases that our app is not androidx, but the library is androidx.

@se-bastiaan
Copy link

I mentioned the reverse option which works fine for an app using support libraries that uses packages that are based on AndroidX.

mnzaki added a commit to mnzaki/react-native-screens that referenced this pull request Nov 27, 2019
)"

This reverts commit ed826d7.

To keep 1.0 branch pre-androidx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants