refactor(iOS, Paper): do not add subviews to header config in HostTree #2553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was just writing #2552 and got confused that the header config subviews are added as subviews to the header config view
in host tree, before they are attached to the navigation bar view hierarchy. This transient state does not make any sense,
and we do not do similar thing on Fabric.
Changes
self.superview
returns nownil
until the subview is mounted in navigation bar view hierarchy.Also moved the function to Paper specific section of file, because it is not called on Fabric on any codepath.
Test code and steps to reproduce
We haven't used this behaviour. There should be no regression in text examples.
Checklist