Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iOS, Paper): do not add subviews to header config in HostTree #2553

Merged

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Dec 6, 2024

Description

I was just writing #2552 and got confused that the header config subviews are added as subviews to the header config view
in host tree, before they are attached to the navigation bar view hierarchy. This transient state does not make any sense,
and we do not do similar thing on Fabric.

Changes

self.superview returns now nil until the subview is mounted in navigation bar view hierarchy.

Also moved the function to Paper specific section of file, because it is not called on Fabric on any codepath.

Test code and steps to reproduce

We haven't used this behaviour. There should be no regression in text examples.

Checklist

@kkafar kkafar merged commit 20808ee into main Dec 6, 2024
5 checks passed
@kkafar kkafar deleted the @kkafar/do-not-add-subviews-to-header-config-in-host-tree branch December 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant