fix(Android): onLayout calls in bottom tabs with freezeOnBlur #2363
+142
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Oct 1, 2024
There was a problem hiding this comment.
I don't remember from the top of my head why we have checked there for container is ScreenStack. Maybe @WoLewicki will have more context here. I'll be able to look into it todays afternoon.
kkafar
reviewed
Oct 2, 2024
WoLewicki
reviewed
Oct 2, 2024
WoLewicki
reviewed
Oct 2, 2024
| @@ -137,7 +137,7 @@ class Screen( | |||
| r: Int, | |||
| b: Int, | |||
| ) { | |||
| if (container is ScreenStack && changed) { | |||
| if (changed) { | |||
There was a problem hiding this comment.
It was added since the logic inside is intended only for native-stack. So I have no idea why removing it would change anything. Can we have more information?
There was a problem hiding this comment.
@WoLewicki I updated the description with some more information. That's all I got, I'll keep on investigating.
alduzy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
freezeOnBluroption not working foronLayoutevents with@react-navigation/bottom-tabsnavigator.In bottom tabs
onLayoutis called inside frozen screens. Re-renders don't happen so it seems like freeze itself is working correctly, except for native events. In native stack nothing is called inside frozen screens as expected (note: native stack with fabric keeps one previous screen unfrozen).Comparing both it seems like calling
updateScreenSizeFabricorupdateScreenSizePapermakes the difference - effectively stopping native event calls in non-active screens.Fixes #2349
Changes
TestFreeze.tsxreproChecklist