Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused code for finding rn version #2288

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

WoLewicki
Copy link
Member

Description

We support RN >= 0.72 so this code is no longer needed.

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right. Please test this on examples / fresh app to ensure we don't break the runtime (cause the artifacts of the modified code are loaded in runtime).

Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aswell!

@WoLewicki WoLewicki merged commit 74335b5 into main Aug 7, 2024
4 checks passed
@WoLewicki WoLewicki deleted the @wolewicki/remove-finding-rn-version branch August 7, 2024 10:28
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
We support RN >= 0.72 so this code is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants