fix(CI): extend logging in architecture-integrity scripts & add NativeProxy.kt to blacklist #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
This was referenced Aug 27, 2024
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 10, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://redirect.github.com/software-mansion/react-native-screens) | [`^3.33.0` -> `^3.34.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.33.0/3.34.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.34.0`](https://redirect.github.com/software-mansion/react-native-screens/releases/tag/3.34.0) [Compare Source](https://redirect.github.com/software-mansion/react-native-screens/compare/3.33.0...3.34.0) Recently released [3.33.0](https://redirect.github.com/software-mansion/react-native-screens/releases/tag/3.33.0) introduced a crash **when running on** Android + Fabric + "bridgefull" combination of platform / architecture. This version introduces a fix for that crash with changes in native code, thus bumping minor version. #### What's Changed #### 🐛 Bug fixes - Android, Fabric, bridge-mode: patch crash with context detached from activity by [@​kkafar](https://redirect.github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2276](https://redirect.github.com/software-mansion/react-native-screens/pull/2276) #### 🔢 Miscellaneous - Extend logging in architecture-integrity scripts & add NativeProxy.kt to blacklist by [@​kkafar](https://redirect.github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2281](https://redirect.github.com/software-mansion/react-native-screens/pull/2281) - Aggregate updates from dependabot by [@​kkafar](https://redirect.github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2267](https://redirect.github.com/software-mansion/react-native-screens/pull/2267) **Full Changelog**: software-mansion/react-native-screens@3.33.0...3.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 10, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://redirect.github.com/software-mansion/react-native-screens) | [`^3.33.0` -> `^3.34.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.33.0/3.34.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.34.0`](https://redirect.github.com/software-mansion/react-native-screens/releases/tag/3.34.0) [Compare Source](https://redirect.github.com/software-mansion/react-native-screens/compare/3.33.0...3.34.0) Recently released [3.33.0](https://redirect.github.com/software-mansion/react-native-screens/releases/tag/3.33.0) introduced a crash **when running on** Android + Fabric + "bridgefull" combination of platform / architecture. This version introduces a fix for that crash with changes in native code, thus bumping minor version. #### What's Changed #### 🐛 Bug fixes - Android, Fabric, bridge-mode: patch crash with context detached from activity by [@​kkafar](https://redirect.github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2276](https://redirect.github.com/software-mansion/react-native-screens/pull/2276) #### 🔢 Miscellaneous - Extend logging in architecture-integrity scripts & add NativeProxy.kt to blacklist by [@​kkafar](https://redirect.github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2281](https://redirect.github.com/software-mansion/react-native-screens/pull/2281) - Aggregate updates from dependabot by [@​kkafar](https://redirect.github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/2267](https://redirect.github.com/software-mansion/react-native-screens/pull/2267) **Full Changelog**: software-mansion/react-native-screens@3.33.0...3.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…eProxy.kt to blacklist (software-mansion#2281) ## Description I was initially confused why the CI fails, so I debugged it a bit and it turned out that we forgot to add `NativeProxy.kt` to blacklist in the integrity scripts. <- Did it. Because of the initial confusion I've decided to add some more logging & error handling mechanisms. ## Test code and steps to reproduce CI now passes. If similar case happens in the future we will get a nice error message. ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was initially confused why the CI fails, so I debugged it a bit and it turned out that we forgot to add
NativeProxy.ktto blacklist in the integrity scripts. <- Did it.Because of the initial confusion I've decided to add some more logging & error handling mechanisms.
Test code and steps to reproduce
CI now passes. If similar case happens in the future we will get a nice error message.
Checklist