fix(Fabric): not working animations on second-top screen #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
kkafar
approved these changes
Jul 30, 2024
Comment on lines
+28
to
+30
| const freezePreviousScreen = isFabric() | ||
| ? size - index > 2 | ||
| : size - index > 1; |
There was a problem hiding this comment.
We need to keep in mind that this is only a heuristics anyway and animations won't work on third-top screen etc.
For now we can proceed.
There was a problem hiding this comment.
I can only see this as a problem when we have multiple transparent modals, in which case I wouldn't enable freeze on that navigator anyway.
Comment on lines
+10
to
+12
| function isFabric() { | ||
| return 'nativeFabricUIManager' in global; | ||
| } |
There was a problem hiding this comment.
IIRC this should be reliably available during the very first render, so we're safe on that front (the value won't differ on first & consecutive renders).
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
This was referenced Sep 28, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…nsion#2270) PR fixing animations on Fabric. The problem started in RN 0.74, from which suspending the component triggers its useLayoutEffect. It has the consequences in Animated since detaching the native node happens then: facebook/react-native@a5b84b9/packages/react-native/Libraries/Animated/useAnimatedProps.js#L221-L238.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixing animations on Fabric.
The problem started in RN
0.74, from which suspending the component triggers itsuseLayoutEffect. It has the consequences inAnimatedsince detaching the native node happens then: https://github.com/facebook/react-native/blob/a5b84b925891fa509bec2e5ee5988bcb0326e198/packages/react-native/Libraries/Animated/useAnimatedProps.js#L221-L238.Changes
Test code and steps to reproduce
Check
Test887.tsxto see that on fabric, when going forward or back, without this change the screen below is not animating.