refact: merge example and test example apps #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
reviewed
Jul 2, 2024
maciekstosio
reviewed
Jul 8, 2024
alduzy
force-pushed
the
@alduzy/merge-example-apps
branch
2 times, most recently
from
f75abdf
to
86d469f
Compare
Co-authored-by: maciekstosio <maciekstosio@icloud.com>
alduzy
force-pushed
the
@alduzy/merge-example-apps
branch
from
5dc1318
to
c5cd87a
Compare
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR intents to merge together the example and test-example apps resulting in less configuration files. TestsExample and FabricTestExample apps are removed so there's only Example, FabricExample and TVOSExample app to take care of. it is more convenient to use Example and FabricExample apps to run tests as there is less configuration files to take care of, less building and less metro restarting. Simply replace the returned component in `apps/App.tsx` with the selected test and you're ready for testing. For example replace `<Example/>` with `<Test.Test42/>`. ## Changes - removed TestsExample and FabricTestExample apps - allowed for source change in `apps/App.tsx` file to switch between example and tests <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce Run the Example or FabricExample app and change source in `apps/App.tsx` file. ## Checklist - [x] Updated documentation: <!-- For adding new props to native-stack --> - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/CONTRIBUTING.md - [x] Ensured that CI passes --------- Co-authored-by: maciekstosio <maciekstosio@icloud.com> Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to merge together the example and test-example apps resulting in less configuration files.
TestsExample and FabricTestExample apps are removed so there's only Example, FabricExample and TVOSExample app to take care of.
it is more convenient to use Example and FabricExample apps to run tests as there is less configuration files to take care of, less building and less metro restarting. Simply replace the returned component in
apps/App.tsxwith the selected test and you're ready for testing. For example replace<Example/>with<Test.Test42/>.Changes
apps/App.tsxfile to switch between example and testsTest code and steps to reproduce
Run the Example or FabricExample app and change source in
apps/App.tsxfile.Checklist