Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Android): fix lint warning of CustomToolbar component #2176

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 8, 2024

Description

Just noticed while working on #2169 that we got a warning in CustomToolbar.

Edit: followed review suggestions and suppressed lints for all our view, where this was requried.

Changes

Suppressed lint on missing constructors.

We're safe to miss these there, as this view is constructed only programatically (we do not inflate any of our views).

Test code and steps to reproduce

N/A

Checklist

  • Ensured that CI passes

@tboba tboba changed the title chore: fix Android lint warning chore(Android): fix lint warning of CustomToolbar component Jun 8, 2024
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm just concerned if we should suppress all of these warnings with unused values like in this PR? What do you think?
Should we maybe do this in that PR?

@kkafar
Copy link
Member Author

kkafar commented Jun 10, 2024

Yeah, I'll look for other places with similar issue and update the PR

@kkafar kkafar merged commit cd2dbe9 into main Jun 17, 2024
4 checks passed
@kkafar kkafar deleted the @kkafar/missing-suppress branch June 17, 2024 13:26
alduzy pushed a commit that referenced this pull request Jun 28, 2024
## Description

Just noticed while working on #2169 that we got a warning in
CustomToolbar.

Edit: followed review suggestions and suppressed lints for all our view,
where this was requried.

## Changes

Suppressed lint on missing constructors. 

We're safe to miss these there, as this view is constructed only
programatically (we do not inflate any of our views).

## Test code and steps to reproduce

N/A

## Checklist

- [ ] Ensured that CI passes
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…-mansion#2176)

## Description

Just noticed while working on software-mansion#2169 that we got a warning in
CustomToolbar.

Edit: followed review suggestions and suppressed lints for all our view,
where this was requried.

## Changes

Suppressed lint on missing constructors. 

We're safe to miss these there, as this view is constructed only
programatically (we do not inflate any of our views).

## Test code and steps to reproduce

N/A

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants