feat: extract shared example and use in in both Example and FabricExa… #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
force-pushed
the
@maciekstosio/Unify-example-app
branch
from
7b91678
to
50e4777
Compare
kkafar
reviewed
May 27, 2024
maciekstosio
force-pushed
the
@maciekstosio/Unify-example-app
branch
from
663bafd
to
92357ae
Compare
kkafar
approved these changes
May 28, 2024
This was referenced Jul 17, 2024
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
software-mansion#2149) ## Description Currently we have separate apps for Example and FabricExample, Example covers most of the features and FabricExample only HeaderConfig, I think it would be better for to share the code base. The main reason is that it's easier to test if features fork the same on both platforms. ## Test code and steps to reproduce FabricExample should look the same, as Example app. <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have separate apps for Example and FabricExample, Example covers most of the features and FabricExample only HeaderConfig, I think it would be better for to share the code base. The main reason is that it's easier to test if features fork the same on both platforms.
Test code and steps to reproduce
FabricExample should look the same, as Example app.