-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing RNScreens in Xcode iOS Swift file fails to compile #2158
Comments
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
The underlying cause seems to be that |
## Description Fixes #2158 by making C++ headers project instead of public. Original code sample (in the issue) can be updated to include this change verifying the fix. ## Checklist - [x] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
## Description Fixes software-mansion#2158 by making C++ headers project instead of public. Original code sample (in the issue) can be updated to include this change verifying the fix. ## Checklist - [x] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Description
Attempting to
import RNScreens
in a swift file inside the main Xcode project where you'd define modules for example cause the build to fail.I've attached a link to a new project I created using Expo.
The only customisation I made was to make CocoaPods use frameworks linking them statically.
The errors I'm getting are:
Steps to reproduce
xcode-select
(haven't tested other Xcode versions)cd
into itnpx expo run:ios
Snack or a link to a repository
https://www.icloud.com/iclouddrive/0f302pmEmM-cWmg6lRoATfeuw#RNScreens-Issue-Reproducer
Screens version
3.31.1
React Native version
0.74.1
Platforms
iOS
JavaScript runtime
Hermes
Workflow
None
Architecture
None
Build type
None
Device
iOS simulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: