Skip to content

Commit

Permalink
fix(iOS): shadow does not appear on manual transition during push and…
Browse files Browse the repository at this point in the history
… pop
  • Loading branch information
maksg committed Jul 8, 2024
1 parent ab065f2 commit 37d59ba
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 0 deletions.
1 change: 1 addition & 0 deletions apps/test-examples/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ import Test2069 from './src/Test2069';
import Test2118 from './src/Test2118';
import Test2184 from './src/Test2184';
import Test2223 from './src/Test2223';
import Test2227 from './src/Test2227';
import Test2229 from './src/Test2229';
import TestScreenAnimation from './src/TestScreenAnimation';
import TestHeader from './src/TestHeader';
Expand Down
57 changes: 57 additions & 0 deletions apps/test-examples/src/Test2227.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import * as React from 'react';
import {NavigationContainer} from '@react-navigation/native';
import {
createNativeStackNavigator,
NativeStackScreenProps,
} from '@react-navigation/native-stack';
import {Button, View, Text} from 'react-native';

type RootStackParamList = {
Home: undefined;
Details: undefined;
};

type HomeScreenProps = NativeStackScreenProps<RootStackParamList, 'Home'>;
type DetailsScreenProps = NativeStackScreenProps<RootStackParamList, 'Details'>;

const Stack = createNativeStackNavigator<RootStackParamList>();

function HomeScreen({navigation}: HomeScreenProps) {
return (
<View style={{flex: 1, justifyContent: 'center', alignItems: 'center'}}>
<Text>Home Screen</Text>
<Button
title="Go to Details"
onPress={() => navigation.navigate('Details')}
/>
</View>
);
}

function DetailsScreen({navigation}: DetailsScreenProps) {
return (
<View style={{flex: 1, justifyContent: 'center', alignItems: 'center'}}>
<Text>Details Screen</Text>
<Button
title="Go to Details Again"
onPress={() => navigation.push('Details')}
/>
<Button title="Go Back" onPress={() => navigation.goBack()} />
<Button title="Go to Home" onPress={() => navigation.navigate('Home')} />
</View>
);
}

export default function App() {
return (
<NavigationContainer>
<Stack.Navigator
screenOptions={{
fullScreenGestureEnabled: true,
}}>
<Stack.Screen name="Home" component={HomeScreen} />
<Stack.Screen name="Details" component={DetailsScreen} />
</Stack.Navigator>
</NavigationContainer>
);
}
1 change: 1 addition & 0 deletions ios/RNSScreenStack.mm
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,7 @@ - (void)handleSwipe:(UIPanGestureRecognizer *)gestureRecognizer
[_interactionController cancelInteractiveTransition];
}
_interactionController = nil;
_isFullWidthSwiping = NO;
}
default: {
break;
Expand Down

0 comments on commit 37d59ba

Please sign in to comment.