Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Worklets): Merge TypeScript type files #6556

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(Worklets): Merge TypeScript type files #6556

wants to merge 3 commits into from

Conversation

tjzel
Copy link
Contributor

@tjzel tjzel commented Sep 27, 2024 •
edited
Loading

Summary

Required by:

NativeReanimatedModule depends on types from Layout Animations - this makes impossible to embed its interface in commonTypes.ts since they can't have any imports. I merged some types to prevent circular dependencies.

Test plan

  • CI Green

@tjzel tjzel mentioned this pull request Sep 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 30, 2024
@tjzel
feat: Expose BaseLayoutAnimationConfig (#6558)
58f8388 
## Summary

If docs need to extract internal types like this we better just export
them publicly.

Fixes CI on:

- #6556
- #6557

## Test plan

🚀
@tjzel tjzel marked this pull request as ready for review September 30, 2024 08:57
This was referenced Sep 30, 2024
Open
Open
@tjzel tjzel changed the title refactor: Merge TypeScript type files refactor(Worklets): Merge TypeScript type files Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomiejbloniarz bartlomiejbloniarz Awaiting requested review from bartlomiejbloniarz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tjzel