Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable TSDoc and JSDoc formatting #6484

Merged
merged 4 commits into from
Sep 8, 2024
Merged

chore: Enable TSDoc and JSDoc formatting #6484

merged 4 commits into from
Sep 8, 2024

Conversation

tjzel
Copy link
Contributor

@tjzel tjzel commented Sep 5, 2024 •
edited
Loading

Summary

Requires:

Test plan

MatiPl01
MatiPl01 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You probably forgot to set @tjzel/bump-prettie as the base branch instead of main, because this PR includes changes from the #6486 but I assume that you will rebase this PR before merging.

@tjzel tjzel added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit 9e5bdc1 Sep 8, 2024
9 of 10 checks passed
@tjzel tjzel deleted the @tjzel/format-jsdoc branch September 8, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@MatiPl01 MatiPl01 MatiPl01 approved these changes

@Latropos Latropos Awaiting requested review from Latropos

@szydlovsky szydlovsky Awaiting requested review from szydlovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjzel @piaskowyk @MatiPl01