Implement styleTransition #6479
Open
+900
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latropos
changed the title
piaskowyk
reviewed
Sep 16, 2024
packages/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsUtils.h
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/LayoutAnimations/BasicLayoutAnimation.tsx
Outdated
Show resolved
Hide resolved
...es/react-native-reanimated/src/layoutReanimation/defaultTransitions/LinearStyleTransition.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsUtils.h
Outdated
Show resolved
Hide resolved
Latropos
changed the title
piaskowyk
reviewed
Sep 23, 2024
packages/react-native-reanimated/src/createAnimatedComponent/commonTypes.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/createAnimatedComponent/createAnimatedComponent.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/createAnimatedComponent/createAnimatedComponent.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/layoutReanimation/animationBuilder/commonTypes.ts
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/SnapshotUtils.h
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/SnapshotUtils.h
Show resolved
Hide resolved
| @@ -684,40 +744,77 @@ void LayoutAnimationsProxy::startExitingAnimation( | |||
|
|
|||
| void LayoutAnimationsProxy::startLayoutAnimation( | |||
There was a problem hiding this comment.
How about introducing a new method called startLayoutTransition? 🤔
There was a problem hiding this comment.
Do you mean startStyleTransition or do you think of renaming all the stuff related to layout Transitions to use naming LayoutTransition instead of LayoutAnimation?
...s/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsManager.cpp
Outdated
Show resolved
Hide resolved
...ges/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsProxy.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Style transition vs layout transition
The layout transition is a feature of reanimated that allows to transform each layout change into smooth animation. Analogously, a style transition will be generalisation of the layout transition - it animates any style change.
Recordings
Screen.Recording.2024-09-19.at.13.26.38.mov
Test plan