Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all autoFixable problems inside app/common #6162

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix all autoFixable problems inside app/common #6162

merged 1 commit into from
Jun 28, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jun 24, 2024

Summary

Run eslint with --fix flag.
These test are broken since when introducing monorepo we unified eslint rules and made them more demanding.

Most of the changes is to prefer import type.

The others are:

  • Remove type cast when its not needed
image
  • Don't have unnecessary conditions
image
  • Use property shorthand
image
  • When possible use const instead of let
image

Test plan

All changes were made automatically.

@Latropos Latropos marked this pull request as ready for review June 25, 2024 09:26
@Latropos Latropos requested review from tomekzaw and piaskowyk June 25, 2024 09:26
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok 👍

@Latropos Latropos added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 71e7b96 Jun 28, 2024
6 checks passed
@Latropos Latropos deleted the auto-fixable branch June 28, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants