-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support snapshots of many views #6047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
piaskowyk
reviewed
Jun 17, 2024
apps/common-app/src/examples/RuntimeTests/tests/TestsOfTestingFramework.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/TestsOfTestingFramework.snapshot.ts
Outdated
Show resolved
Hide resolved
...common-app/src/examples/RuntimeTests/tests/layoutAnimations/entering/enteringColors.test.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/util.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/TestComponent.ts
Show resolved
Hide resolved
...mmon-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/matchers/snapshotMatchers.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/UpdatesContainer.ts
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/UpdatesContainer.ts
Show resolved
Hide resolved
piaskowyk
approved these changes
Jun 17, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously recording snapshots of component containing multiple views were generating array of all the updates in random order.
The new API is as follows:
If you don't specify any component, but snapshot recorded more than one an error is thrown. Same if you specify a component, but there is only one recording.
Other changes in this PR include:
Test plan
File
Animations.test.tsx
was renamed intoTestsOfTestingFramework.test.tsx
, include some tests of snapshot mismatch (and mismatch of callback functions)Tested on Paper, on IOS and Android. Some of the fixes, created to make tests work well on Android, were extracted into separate PR #6084