Use web implementation for gesture handlers in Jest #2747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Dec 18, 2021
This was referenced Jan 25, 2022
Merged
piaskowyk
pushed a commit
that referenced
this pull request
Jan 27, 2022
## Description Extracted from #2747. RNGH needs to use useAnimatedGestureHandler in Jest environment so we want to use web implementation there. ## Checklist - [x] Ensured that CI passes
aeddi
pushed a commit
to aeddi/react-native-reanimated
that referenced
this pull request
Mar 22, 2022
## Description Extracted from software-mansion#2747. RNGH needs to use useAnimatedGestureHandler in Jest environment so we want to use web implementation there. ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want to add support for gesture-handler events in Jest. I want to make it user-friendly, so I am adding changes to react-native-gesture-handler. During this, I noticed that reanimated sometimes tried to use native implementation instead of web implementation. So I changed it to prevent mocking
Platform.OS.Related PR: software-mansion/react-native-gesture-handler#1762