-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Ignore comments in validation scripts (#6554)
🚀 Also fixing unescaped double quotes. Adding @jfedak as reviewer because GitHub suggested him 🤷
- Loading branch information
Showing
3 changed files
with
12 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #!/bin/bash | ||
|
|
||
| if grep -Rn android/src/main/cpp -e '#include "' ; then | ||
| echo "Found \`#include "..."\` in \`android/src/main/cpp/\` directory. Convert it to \`#include <...>\`, e.g. \`#include <reanimated/AndroidUIScheduler.h>\`." && false | ||
| if grep -Rn android/src/main/cpp -e '^#include "'; then | ||
| echo 'Found `#include "..."` in `android/src/main/cpp/` directory. Convert it to `#include <...>`, e.g. `#include <reanimated/AndroidUIScheduler.h>`.' && false | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| #!/bin/bash | ||
|
|
||
| if grep -Rn apple -e '#include ' ; then | ||
| echo "Found \`#include\` in \`apple/\` directory. Convert it to \`#import\`, e.g. \`#import <reanimated/apple/REAModule.h>\`." && false | ||
| if grep -Rn apple -e '^#include '; then | ||
| echo 'Found `#include` in `apple/` directory. Convert it to `#import`, e.g. `#import <reanimated/apple/REAModule.h>`.' && false | ||
| fi | ||
|
|
||
| if grep -Rn apple -e '#import "' ; then | ||
| echo "Found \`#import "..."\` in \`apple/\` directory. Convert it to \`#import <...>\`, e.g. \`#import <reanimated/apple/REAModule.h>\`." && false | ||
| if grep -Rn apple -e '^#import "'; then | ||
| echo 'Found `#import "..."` in `apple/` directory. Convert it to `#import <...>`, e.g. `#import <reanimated/apple/REAModule.h>`.' && false | ||
| fi | ||
|
|
||
| if grep -Rn apple -e '<RNReanimated/' ; then | ||
| echo "Found \`#import <RNReanimated/...>\` in \`apple/\` directory. Convert it to \`#import <reanimated/...>\`, e.g. \`#import <reanimated/apple/REAModule.h>\`." && false | ||
| if grep -Rn apple -e '^#import <RNReanimated/'; then | ||
| echo 'Found `#import <RNReanimated/...>` in `apple/` directory. Convert it to `#import <reanimated/...>`, e.g. `#import <reanimated/apple/REAModule.h>`.' && false | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| #!/bin/bash | ||
|
|
||
| if grep -Rn Common/cpp -e '#include "' ; then | ||
| echo "Found \`#include "..."\` in \`Common/cpp/\` directory. Convert it to \`#include <...>\`, e.g. \`#include <reanimated/Fabric/PropsRegistry.h>\`." && false | ||
| if grep -Rn Common/cpp -e '^#include "'; then | ||
| echo 'Found `#include "..."` in `Common/cpp/` directory. Convert it to `#include <...>`, e.g. `#include <reanimated/Fabric/PropsRegistry.h>`.' && false | ||
| fi | ||
|
|
||
| if grep -Rn Common/cpp/worklets -e '#include <reanimated/' ; then | ||
| echo "Found \`#include <reanimated/...>\` in \`Common/cpp/worklets/'\` directory which is not allowed." && false | ||
| if grep -Rn Common/cpp/worklets -e '^#include <reanimated/'; then | ||
| echo 'Found `#include <reanimated/...>` in `Common/cpp/worklets/` directory which is not allowed.' && false | ||
| fi |