Fix for Swipeable freezing app (due to change in interpolate implementation) #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
This is fix for broken behavior of Swipeable on newer version of React Native (where interpolate do not accept inputRange elements that are not growing/descending). When `rigthWidth` is set to `0` (like when we load data to `Swipeable`) app is freezing for few seconds. I expect that similar behavior could be reproduced for `leftWidth`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for broken behavior of Swipeable on newer version of React Native (where interpolate do not accept inputRange elements that are not growing/descending).
When
rigthWidthis set to0(like when we load data toSwipeable) app is freezing for few seconds.I expect that similar behavior could be reproduced for
leftWidth.