Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GestureDetector #2901

Merged
merged 26 commits into from
May 16, 2024
Merged

Refactor GestureDetector #2901

merged 26 commits into from
May 16, 2024

Commits on May 9, 2024

  1. Move to separate directory

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3a267b0 View commit details
    Browse the repository at this point in the history

  2. Split into multiple files

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    04ce6cb View commit details
    Browse the repository at this point in the history

  3. Propagate relevant detector props to gestures helper

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5066297 View commit details
    Browse the repository at this point in the history

  4. Use correct tense in error message

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e2aca75 View commit details
    Browse the repository at this point in the history

  5. Small renames

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    23d8caa View commit details
    Browse the repository at this point in the history

  6. More renames

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4ba074b View commit details
    Browse the repository at this point in the history

  7. Warn when none of the callbacks are worklest, only throw in dev

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f92267e View commit details
    Browse the repository at this point in the history

  8. More renames

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d0d841b View commit details
    Browse the repository at this point in the history

  9. This one may be tricky, but I think the end result is the same

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    91c4fc0 View commit details
    Browse the repository at this point in the history

  10. Move relations to helper

    @j-piasecki
    j-piasecki committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2626bb2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Rename GestureConfigReference -> AttachedGestureState

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    782ec5b View commit details
    Browse the repository at this point in the history

  2. Add comment

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2d26817 View commit details
    Browse the repository at this point in the history

  3. Allow thread switching, no idea why it was disabled

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    48d3397 View commit details
    Browse the repository at this point in the history

  4. Don't show warning when no Reanimated

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    16d4598 View commit details
    Browse the repository at this point in the history

  5. Move mounted flag into the attached gesture state

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    90c9a5f View commit details
    Browse the repository at this point in the history

  6. Rename and move assignment

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9eee2b8 View commit details
    Browse the repository at this point in the history

  7. Update src/handlers/gestures/GestureDetector/utils.ts 

    Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
    @j-piasecki @m-bert
    j-piasecki and m-bert committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3b07b17 View commit details
    Browse the repository at this point in the history

  8. Update src/handlers/gestures/GestureDetector/index.tsx 

    Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
    @j-piasecki @m-bert
    j-piasecki and m-bert committed May 10, 2024
    Configuration menu
    Copy the full SHA
    781f294 View commit details
    Browse the repository at this point in the history

  9. Update src/handlers/gestures/GestureDetector/utils.ts 

    Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
    @j-piasecki @m-bert
    j-piasecki and m-bert committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d715f9c View commit details
    Browse the repository at this point in the history

  10. Fix braces

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7f83166 View commit details
    Browse the repository at this point in the history

  11. More renames, move web handlers creation to hook

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    007a0d9 View commit details
    Browse the repository at this point in the history

  12. Add comment abount blockHandler

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    040e385 View commit details
    Browse the repository at this point in the history

  13. Extract more logic into hooks

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9ad420b View commit details
    Browse the repository at this point in the history

  14. Small optimizations

    @j-piasecki
    j-piasecki committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d114ce4 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Flatten ifs

    @j-piasecki
    j-piasecki committed May 14, 2024
    Configuration menu
    Copy the full SHA
    bab8167 View commit details
    Browse the repository at this point in the history

  2. Remove validation from ref handler

    @j-piasecki
    j-piasecki committed May 14, 2024
    Configuration menu
    Copy the full SHA
    067a8de View commit details
    Browse the repository at this point in the history