Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up a new Github Action Application for AI Support #3
Setting up a new Github Action Application for AI Support #3
Changes from 93 commits
5e39d6a
ea756f4
d1b19df
359de21
38d26f0
1fcadcd
44903e2
d040757
19ece9f
00fbc88
cd1f545
cd7612e
2eea851
d1548d2
c255374
2670f16
3ba739b
9e7b01e
ad28ce7
90edab3
9779458
3392d42
c44418b
f9d9fb8
9532026
13af433
5a1f0b1
9235dd5
84608b5
926f206
08084a8
a17cbdf
1d3de99
f31493d
27ffb14
328e9f7
9c15f54
c892320
6867bab
288b79a
3d3f2da
443ee90
f699e0f
ecfa3df
eda91ff
93b24a1
716ada6
7e0ebe9
c244bfc
e91ae52
6691a7c
72eb518
3f4b20e
2f08e55
434df9b
76d58df
8bf7caf
df108ec
42b7769
78060e8
e1f0363
7fe820f
6660840
312f03f
61746e2
a52477e
764c820
6e79ab1
f54bd21
b73aea8
4795359
89d1351
1c77949
1eb203c
a4d7d5b
d051108
34a9de8
56a1938
042c527
dd04a67
99a9db5
0e6e6b7
4c62433
f1b4568
f1cb5f0
982a3b6
b25ee58
0a8671d
9219d7c
3b00d80
ed7639e
ddd2990
f73b3d7
7bf63f1
58e54ff
ab9f568
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarrellRichards make this configurable but defaulted to this model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already completed (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo here. The input key should be
excluded_files
instead ofexpluded_files
.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation for this line should be adjusted to match the surrounding code style. It seems to have an extra space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
if (resultsFullFeedback)
check introduced here is a good safeguard. Ensure that thesummaryOfAllFeedback
function indeed returnsnull
,undefined
, or an equivalent falsy value in cases where no feedback is generated. This will prevent potential silent failures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
neededComments
is an array, the previous check forneededComments && neededComments.length > 0
ensures that comments are only created when there are actual elements in the array. The new conditionif (neededComments)
is less restrictive as it will be true even ifneededComments
is an empty array, potentially leading to unnecessary API calls. Consider reverting to the original condition to avoid such scenarios.