Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password update #62

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Password update #62

merged 3 commits into from
Jul 9, 2020

Conversation

alejandrosaenz117
Copy link
Collaborator

Pull Request

Thank you for your contribution to the Bulwark. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #50

Type of change

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

The feature gives the ability for a user to update their password via their user profile.

Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alejandrosaenz117
feat(user-profile component): ability to update user password
9855987 
Give's the user the ability to update their password

feat #50
@alejandrosaenz117
feat(user-profile.component.ts): wired API to auth service and user prof
6b6eb36 
Wired API to auth service and user profile so that a user can update their password via their
profile

feat #50
@alejandrosaenz117
refactor(user-profile.component.html .spec.ts): updated element ID
e91f40c 
Updated element ID of security form.  Removed priority Unit Testing flag

re #50
skewled
skewled approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@skewled skewled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall and I see no issues with breaking any implementations from the added feature.

@alejandrosaenz117 alejandrosaenz117 merged commit a3b591a into develop Jul 9, 2020
@alejandrosaenz117 alejandrosaenz117 deleted the password-update branch July 9, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skewled skewled skewled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejandrosaenz117 @skewled