Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report sort #494

Merged
merged 2 commits into from
Dec 12, 2020
Merged

Report sort #494

merged 2 commits into from
Dec 12, 2020

Conversation

alejandrosaenz117
Copy link
Collaborator

Pull Request

Thank you for your contribution to the Bulwark. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #482

Type of change

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

Implemented sorting for report vulnerabilities by overall risk severity.

Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alejandrosaenz117
feat(report.component): implement overall risk sort
e31c76c 
Implemented vulnerability sorting by overall risk severity.  Fixed table header issue on report
causing bold text.

feat #482
@alejandrosaenz117
chore(report.component): fix lint issue
aca3ea9 
feat #482
@alejandrosaenz117 alejandrosaenz117 linked an issue Dec 11, 2020 that may be closed by this pull request
Implement Report Vulnerability Sorting #482
Closed
@skewled skewled merged commit 0fe362d into develop Dec 12, 2020
@alejandrosaenz117 alejandrosaenz117 deleted the reportSort branch December 12, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skewled skewled skewled approved these changes

@waterweasel4 waterweasel4 Awaiting requested review from waterweasel4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Report Vulnerability Sorting
2 participants
@alejandrosaenz117 @skewled