-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 #45
Merged
Merged
Release 1.0.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed all linting issues. added additional package.json linting scripts
Updating package.json scripts so it runs on at least windows and osx
on-behalf-of: @softrams <opensource@softrams.com>
Housekeeping
#38 changes to start/end date in assessment form
…e with instructions
Seed Initial User
Fixed broken link
Implemented commitizen and husky to add committing standarizations to Bulwark. Developers must now craft proper commit messages when adding code
implemented commitizen with husky to enforce commit standards. added pull-request template. #43
Implement Conventional Commit Standards
Added Joshua Seidel as a contributor for the updates to the documentation. Increased to version to 1 now that the application is semi-stable.
skewled
approved these changes
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the entries are linting corrections as well as array notation conversion to object notation with member functions. There were no issues spotted when reviewing the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Release 1.0.0
Types of changes
When we released Bulwark to open source, we found bugs that we otherwise would not have found such as creating package.json scripts that worked on windows machines. Furthermore, the documentation has been vastly improved by adding a pull request template, feature template, bug template, and security process template. A Code of Conduct page was also created for our users.
When it comes to the simplicity of starting Bulwark, there was some confusion on how to create the initial Bulwark user. This functionality required an insert to the database or a code change. Instead, a seed function was created to make it easier to create the first user. Additionally, Husky and Commitizen were both implemented to enforce conventional commits.
Checklist