Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #45

Merged
merged 15 commits into from
May 15, 2020
Merged

Release 1.0.0 #45

merged 15 commits into from
May 15, 2020

Conversation

alejandrosaenz117
Copy link
Collaborator

@alejandrosaenz117 alejandrosaenz117 commented May 15, 2020

Pull Request

Release 1.0.0

Types of changes

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

When we released Bulwark to open source, we found bugs that we otherwise would not have found such as creating package.json scripts that worked on windows machines. Furthermore, the documentation has been vastly improved by adding a pull request template, feature template, bug template, and security process template. A Code of Conduct page was also created for our users.

When it comes to the simplicity of starting Bulwark, there was some confusion on how to create the initial Bulwark user. This functionality required an insert to the database or a code change. Instead, a seed function was created to make it easier to create the first user. Additionally, Husky and Commitizen were both implemented to enforce conventional commits.


Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

alejandrosaenz117 and others added 15 commits May 9, 2020 22:04
fixed all linting issues.  added additional package.json linting scripts
Updating package.json scripts so it runs on at least windows and osx
on-behalf-of: @softrams <opensource@softrams.com>
#38 changes to start/end date in assessment form
Fixed broken link
Implemented commitizen and husky to add committing standarizations to Bulwark.  Developers must now
craft proper commit messages when adding code
implemented commitizen with husky to enforce commit standards.  added pull-request template.

#43
Implement Conventional Commit Standards
Added Joshua Seidel as a contributor for the updates to the documentation.  Increased to version to
1 now that the application is semi-stable.
@alejandrosaenz117 alejandrosaenz117 changed the title Develop Release 1.0.0 May 15, 2020
Copy link
Contributor

@skewled skewled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the entries are linting corrections as well as array notation conversion to object notation with member functions. There were no issues spotted when reviewing the changes.

@alejandrosaenz117 alejandrosaenz117 merged commit 09ccb6b into master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants