Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ability to update user email address #353

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Implement the ability to update user email address #353

merged 4 commits into from
Oct 13, 2020

Conversation

alejandrosaenz117
Copy link
Collaborator

Pull Request

Thank you for your contribution to the Bulwark. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #49

Type of change

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

Added the ability for user's to update their email address for the application. This includes email verification.

Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

alejandrosaenz117 and others added 4 commits October 8, 2020 16:13
@alejandrosaenz117
feat(add user entity column for newemail): update user entity with ne…
4aef2fe 
…wEmail column

Updated user entity with newEmail column. Fixed failing unit tests for the user controller. added
contact information form to component.

BREAKING CHANGE: added new newEmail column to the user entity

feat #49
@alejandrosaenz117
feat(user controller): created API for email update
bcbab8f 
feat #49
@alejandrosaenz117
feat(new api for revoke and validate email request): new api's with u…
152cbf1 
…nit tests

Added new API for revoking and validating an email update request.  This update included it's
related unit tests.  Updated user-profile component with updated form.  Added new api's to auth
service.

feat #49
@alejandrosaenz117
feat(email-validate component): created the email-validate.component.…
5c1dd87 
…ts file

Created the email-validate.component.ts file and wired it to use the API. Fixed unit tests for the
user controller.

close #49
@alejandrosaenz117 alejandrosaenz117 linked an issue Oct 13, 2020 that may be closed by this pull request
Ability to update user email #49
Closed
@skewled skewled merged commit 7046110 into develop Oct 13, 2020
@alejandrosaenz117 alejandrosaenz117 deleted the user_email branch October 13, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skewled skewled skewled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to update user email
2 participants
@alejandrosaenz117 @skewled