Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed User Fix #213

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Seed User Fix #213

merged 3 commits into from
Aug 17, 2020

Conversation

alejandrosaenz117
Copy link
Collaborator

Pull Request

Fixes #208

Type of change

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

Fixed broken user seeding. Refactored README by separating initial database setup and initial user creation

Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alejandrosaenz117
fix(seed initial user fix): update seed user script so that it uses C…
14d0e38 
…LI arguments

Fixed seed user script by refactoring it to ingest user input via CLI arguments

fix #208
@alejandrosaenz117
fix(updated readme. added initial migration script): updated the READ…
c954694 
…ME with updated initial steps

Updated the READEME with updated initial steps which include initializing the first database
migration and inserting the first user.

fix #208
@alejandrosaenz117
fix(ormconfig): updated ormconfig migrations array
afba021 
Fixed migrations bug where the server would not start due to misconfigured migrations

fix #208
@alejandrosaenz117 alejandrosaenz117 merged commit 9d53a49 into master Aug 17, 2020
@alejandrosaenz117 alejandrosaenz117 deleted the 208-master branch August 17, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seed initial user process is broken
1 participant
@alejandrosaenz117