Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Security Report with 0 findings #37

Closed
alejandrosaenz117 opened this issue May 12, 2020 · 1 comment
Closed

Update Security Report with 0 findings #37

alejandrosaenz117 opened this issue May 12, 2020 · 1 comment
Assignees
@alejandrosaenz117
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alejandrosaenz117
Copy link
Collaborator

alejandrosaenz117 commented May 12, 2020 •
edited
Loading

When a report with 0 findings is generated, the vulnerability summary table still shows and an additional page is also created. This may be confusing for the reader.

A 0 finding report should replace the vulnerability summary table with a clear an concise message such as "No vulnerabilities were found during this assessment."
@alejandrosaenz117 alejandrosaenz117 added enhancement New feature or request good first issue Good for newcomers labels May 12, 2020
@alejandrosaenz117 alejandrosaenz117 added the help wanted Extra attention is needed label May 19, 2020
@alejandrosaenz117 alejandrosaenz117 self-assigned this Jul 11, 2020
@alejandrosaenz117
Copy link
Collaborator Author

This ticket will also handle if any of the following do not exist:

  • Executive Summary
  • Problem Locations
  • Resources
  • Screenshots

alejandrosaenz117 added a commit that referenced this issue Jul 11, 2020
@alejandrosaenz117
feat(report.component.html): implemented dynamic report properties
8a1300e 
Implemented dynamic report properties that include the executive summary, problem locations,
resources, and screenshots.

feat #37
@alejandrosaenz117 alejandrosaenz117 mentioned this issue Jul 11, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alejandrosaenz117 alejandrosaenz117

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alejandrosaenz117