-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push from non-tag triggered workflows if name is specified #38
base: master
Are you sure you want to change the base?
Conversation
Debug log from
|
I just saw this pull after #39. Does that also solve the solve for this case as well? |
Hmm, I thought github release names had to match a tag name? So how would having both a name and a tag_name input parameter work? I see this action can create a draft release so in that case I think you can create the draft release before the tag, but I guess my question would be: If we're using |
On Windows, prettier doesn't seem to accept wildcards.
Release name and tag name can be different. |
I'll check out that other pull request today or tomorrow and close this pull request if that covers my case. |
Any update? |
The change here is to not require a tag-triggered workflow if the
name
input is passed to action-gh-release.Resolves: #20
Successful branch-triggered workflow: https://github.com/Alkrun/Sidekick/commit/c759ce5b61785628c77274e05a464b43aa34d648/checks?check_suite_id=390802627
I'm probably going to squash my commits from that repo so to preserve the github action workflow it's pasted below. This is a dotnet core project, the
Tag
andRelease
steps are probably the only interesting ones related to this pull request: