Upgrade to Ember CLI 0.2.3 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the addon install command in the README and the application.hbs. |
| @@ -18,6 +18,7 @@ indent_style = space | |||
| indent_size = 2 | |||
|
|
|||
| [*.hbs] | |||
| insert_final_newline = false | |||
| indent_style = space | |||
| indent_size = 2 | |||
There was a problem hiding this comment.
https://github.com/softlayer/sl-ember-test-helpers/pull/72/files changed "indent_size" property throughout this file in that repo but the same changes were not made here. We should be consistent across the repositories in this regard.
| * component is rendered into the DOM is adhered to. | ||
| */ | ||
| test( 'Renders as a span tag with no classes', function( assert ) { | ||
| var component = this.subject({ translateService: translateService }), | ||
| $component = this.render(); | ||
| var component = this.subject({ translateService }); |
There was a problem hiding this comment.
Do not need assignment to var
|
https://github.com/softlayer/sl-ember-translate#binding needs to be changed to reflect the "Binding" changes |
| "glob": "^4.5.1", | ||
| "sl-ember-test-helpers": "1.3.0" | ||
| "ember-disable-prototype-extensions": "^1.0.0", | ||
| "ember-try": "0.0.4", |
notmessenger
added a commit
that referenced
this pull request
Apr 17, 2015
Upgrade to Ember CLI 0.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.