Ember.typeOf( Symbol ) returns "function", which will cause problems in this code

[notmessenger]

sl-ember-test-helpers/test-support/helpers/sl/utils/utils.js

Line 21 in e0e301b

'object' === Ember.typeOf( underTest )

sl-ember-test-helpers/test-support/helpers/sl/synchronous/contains.js

Line 33 in e0e301b

'object' === Ember.typeOf( underTest ) ||

emberjs/ember.js#11673 has been opened regarding this issue in Ember.js so depending on the timing of when the issue is worked on it might already be resolved or we will need to accommodate it via a workaround in our code via using typeof. If we do the latter then we need to create an issue to remove our workaround once emberjs/ember.js#11673 is resolved and released.

[stefanpenner]

im curious why this library doesn't just use typeof ? It doesn't appear to care about anything Ember.typeOf adds

[notmessenger]

@stefanpenner We have been able to replace Array.isArray() checks such as in softlayer/sl-ember-translate@941cf03 when using Ember.typeOf(), as well as other standardization features Ember.typeOf() provides. As such, we elected to enforce its usage across the board (https://github.com/softlayer/ember-style-guide#type-checking) for our projects for consistency. And since any additional processing that might be incurred is only via the use of Ember.asserts() that get stripped out of production builds anyway we haven't encountered any issues.

If there is something missing in our approach or any recommendations you can make we're all ears!

[notmessenger]

emberjs/ember.js#11673 is not going to be resolved at this time so calls to Ember.typeOf() that are compared to 'object' must also contain logic similar to && 'symbol' != typeof

[notmessenger]

Will need to use jshint ignore entries like in https://github.com/softlayer/sl-ember-components/blob/688911c66d7a678fab6ff935b332d76593b5b400/addon/components/sl-chart.js#L95