[feat] 어드민 기대평 여러가지 #113
Merged
[feat] 어드민 기대평 여러가지 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lybell-art
approved these changes
Aug 19, 2024
Comment on lines
+54
to
+61
| function truncateString(str) { | ||
| if (str.length > 50) { | ||
| return str.substring(0, 50) + "..."; | ||
| } else { | ||
| return str; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
만약 기대평이 한글만으로 이루어져 있을 때와, 영어로만 이루어져 있을 때를 상상해보셨나요?
한글이 영어보다 더 넓기 때문에 순수하게 문자열의 길이를 이용해 말줄임표를 구현하는 것보다는 css를 쓰는 게 적절합니다. (https://tailwindcss.com/docs/text-overflow#truncate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용