Remove lookout #1447
Remove lookout #1447
Conversation
WalkthroughThe changes involve the removal of dependencies related to the Lookout metrics library from various Maven POM files, including Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
bom/pom.xml (1)
Remove remaining
lookoutreferences from the codebaseThe removal of the
lookoutlibrary dependencies frompom.xmlis incomplete. Several files still contain references tolookout, which may lead to compilation errors, runtime issues, or confusion for developers. Please address the following:
- Remove
lookoutimports and usages from:
tracer/tracer-opentracing-resteasy/src/main/java/com/alipay/sofa/rpc/server/rest/LookoutRequestFilter.javaremoting/remoting-resteasy/src/main/java/com/alipay/sofa/rpc/server/rest/SofaRestRequestHandler.java- Delete or refactor the following
lookout-related files:
remoting/remoting-resteasy/src/main/java/com/alipay/sofa/rpc/lookout/RestLookoutAdapter.javaremoting/remoting-resteasy/src/main/java/com/alipay/sofa/rpc/lookout/RestConstants.java- Update
core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.javato remove theLOOKOUT_COLLECT_DISABLEoption.- Remove or update the
lookout-related log code incore/api/src/main/resources/sofa-rpc/logcodes-common_en.properties.Ensure that all
lookout-related functionality is properly removed or replaced to maintain the consistency and stability of the codebase.Analysis chain
Line range hint
1-1: Verify the impact of removing thelookoutlibrary dependencies.The dependency declarations for
lookout-apiandlookout-corehave been completely removed, which aligns with the PR objective to remove the "lookout" component from the project.Please ensure that the removal of the
lookoutlibrary dependencies doesn't break any existing functionality or cause runtime exceptions in the codebase.Run the following script to search for potential
lookoutlibrary usage in the codebase:Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for potential `lookout` library usage in the codebase. # Test: Search for `lookout` package imports. Expect: No results. rg --type java 'import com\.alipay\.lookout\.' # Test: Search for `lookout` class references. Expect: No results. rg --type java -w 'lookout'Length of output: 1049
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (22)
- all/pom.xml (1 hunks)
- bom/pom.xml (1 hunks)
- core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1 hunks)
- metrics/metrics-lookout/pom.xml (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/event/LookoutSubscriber.java (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcAbstractLookoutModel.java (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcClientLookoutModel.java (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookout.java (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcServerLookoutModel.java (0 hunks)
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/module/LookoutModule.java (0 hunks)
- metrics/metrics-lookout/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.module.Module (0 hunks)
- metrics/metrics-lookout/src/test/java/com/alipay/sofa/rpc/module/ConsumerSubTest.java (0 hunks)
- metrics/metrics-lookout/src/test/java/com/alipay/sofa/rpc/module/LookoutModuleTest.java (0 hunks)
- metrics/metrics-lookout/src/test/java/com/alipay/sofa/rpc/module/ProviderPubTest.java (0 hunks)
- metrics/pom.xml (0 hunks)
- registry/registry-sofa/pom.xml (0 hunks)
- test/test-integration/pom.xml (0 hunks)
- test/test-integration/src/test/java/com/alipay/sofa/rpc/metrics/lookout/LookoutService.java (0 hunks)
- test/test-integration/src/test/java/com/alipay/sofa/rpc/metrics/lookout/LookoutServiceImpl.java (0 hunks)
- test/test-integration/src/test/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookoutTest.java (0 hunks)
- test/test-integration/src/test/java/com/alipay/sofa/rpc/server/rest/RestLookoutTest.java (0 hunks)
Files not reviewed due to no reviewable changes (19)
- metrics/metrics-lookout/pom.xml
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/event/LookoutSubscriber.java
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcAbstractLookoutModel.java
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcClientLookoutModel.java
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookout.java
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcServerLookoutModel.java
- metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/module/LookoutModule.java
- metrics/metrics-lookout/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.module.Module
- metrics/metrics-lookout/src/test/java/com/alipay/sofa/rpc/module/ConsumerSubTest.java
- metrics/metrics-lookout/src/test/java/com/alipay/sofa/rpc/module/LookoutModuleTest.java
- metrics/metrics-lookout/src/test/java/com/alipay/sofa/rpc/module/ProviderPubTest.java
- metrics/pom.xml
- registry/registry-sofa/pom.xml
- test/test-integration/pom.xml
- test/test-integration/src/test/java/com/alipay/sofa/rpc/metrics/lookout/LookoutService.java
- test/test-integration/src/test/java/com/alipay/sofa/rpc/metrics/lookout/LookoutServiceImpl.java
- test/test-integration/src/test/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookoutTest.java
- test/test-integration/src/test/java/com/alipay/sofa/rpc/server/rest/RestLookoutTest.java
Additional comments not posted (3)
core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1)
532-532: Deprecation ofLOOKOUT_COLLECT_DISABLEconstant is appropriate.Marking the
LOOKOUT_COLLECT_DISABLEconstant as deprecated aligns with the objective of removing the Lookout metrics library. This communicates that the constant should not be used in new code.Please ensure that any existing code referencing this constant is updated to remove its usage.
bom/pom.xml (1)
35-35: LGTM!The
hessian.versionproperty has been updated from3.5.4to3.5.5, which is a minor version bump. This should be a safe update that includes bug fixes and improvements while maintaining backward compatibility.all/pom.xml (1)
62-62: Verify compatibility of thehessianversion update.The
hessian.versionhas been updated from3.5.4to3.5.5. This appears to be a minor version update, but it's important to ensure compatibility with the rest of the project.Please run the following script to search for any usage of the
hessianlibrary in the codebase and verify that the version update doesn't introduce any issues:Also, ensure that all tests pass successfully after updating the version.
Verification successful
Hessian version update approved, but careful testing is crucial.
The update of the
hessianlibrary from version 3.5.4 to 3.5.5 is a minor version change that likely includes bug fixes and improvements. Given the extensive use of Hessian throughout the project, including custom implementations and extensions, this update is approved but with the following important considerations:
- Conduct thorough testing across all components that use Hessian serialization to ensure compatibility with the new version.
- Pay special attention to the
sofa-rpc-codec-sofa-hessianmodule and any custom Hessian serialization implementations.- Verify that both Hessian and Hessian2 serialization protocols continue to function correctly.
- Review the security implications mentioned in SECURITY.md, ensuring that existing security measures (such as blacklisting) remain effective with the new version.
- Update any version-specific documentation or comments in the code to reflect the new Hessian version.
After implementing the update, please run a comprehensive test suite and monitor for any unexpected behavior in production environments.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for usage of the `hessian` library in the codebase. # Test: Search for import statements of the `hessian` library. rg --type java 'import com\.alipay\.sofa\.hessian\.'Length of output: 54
Script:
#!/bin/bash # Description: Perform a broader search for `hessian` usage in the codebase # Search for 'hessian' in all files echo "Searching for 'hessian' in all files:" rg -i 'hessian' --type-add 'xml:*.xml' --type-add 'properties:*.properties' # Search for 'hessian' dependency in pom.xml files echo -e "\nSearching for 'hessian' dependency in pom.xml files:" rg -i '<artifactId>hessian</artifactId>' --type xml # List all pom.xml files that contain 'hessian' echo -e "\nListing pom.xml files containing 'hessian':" rg -i 'hessian' --type xml --files-with-matchesLength of output: 71050
fix 针对 上游 sofa-rpc-all 清理 Lookout sofastack/sofa-rpc#1447 修复类缺失问题
fix 针对 上游 sofa-rpc-all 清理 Lookout sofastack/sofa-rpc#1447 修复类缺失问题
Remove lookout
Summary by CodeRabbit
New Features
Bug Fixes
LOOKOUT_COLLECT_DISABLEconstant to prevent its usage in new code.Documentation
Chores