Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize UserThreadPoolManager #1390

Merged

Conversation

wangchengming666
Copy link
Collaborator

Optimize UserThreadPoolManager, Replace the original for loop with addAll.

@wangchengming666
Copy link
Collaborator Author

@EvenLjj @OrezzerO pls help review

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (9faa8b8) 72.04% compared to head (4494257) 72.01%.
Report is 4 commits behind head on master.

Files Patch % Lines
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 53.06% 16 Missing and 7 partials ⚠️
.../sofa/rpc/dynamic/DynamicConfigManagerFactory.java 0.00% 6 Missing ⚠️
...ava/com/alipay/sofa/rpc/server/UserThreadPool.java 75.00% 2 Missing and 2 partials ⚠️
...ipay/sofa/rpc/codec/jackson/JacksonSerializer.java 93.54% 0 Missing and 2 partials ⚠️
...ipay/sofa/rpc/codec/jackson/JacksonConfigKeys.java 88.88% 1 Missing ⚠️
...sofa/rpc/common/threadpool/ThreadPoolConstant.java 0.00% 1 Missing ⚠️
...threadpool/extension/VirtualThreadPoolFactory.java 50.00% 1 Missing ⚠️
.../alipay/sofa/rpc/server/UserVirtualThreadPool.java 83.33% 1 Missing ⚠️
...a/com/alipay/sofa/rpc/event/LookoutSubscriber.java 66.66% 0 Missing and 1 partial ⚠️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1390      +/-   ##
============================================
- Coverage     72.04%   72.01%   -0.04%     
- Complexity      785      792       +7     
============================================
  Files           417      422       +5     
  Lines         17709    17804      +95     
  Branches       2760     2769       +9     
============================================
+ Hits          12759    12821      +62     
- Misses         3546     3567      +21     
- Partials       1404     1416      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj requested a review from Lo1nt February 28, 2024 03:38
@EvenLjj EvenLjj merged commit df2dcae into sofastack:master Feb 29, 2024
5 checks passed
@wangchengming666 wangchengming666 deleted the opt-UserThreadPoolManager branch March 1, 2024 05:34
wangchengming666 pushed a commit to wangchengming666/sofa-rpc that referenced this pull request Mar 22, 2024
support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

fix

support sofa registry kubernetes

fix KubernetesRegistryHelper

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support k8s registry

support k8s registry

update rpc version to 5.13.0-SNAPSHOT (sofastack#1396)

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>

optimize UserThreadPoolManager (sofastack#1390)

Co-authored-by: 呈铭 <beck.wcm@antgroup.com>

fix sofastack#1380, create NacosRegistryProviderObserver when init method is executed  (sofastack#1401)

* fix sofastack#1380

* fix sofastack#1380

---------

Co-authored-by: 呈铭 <beck.wcm@antgroup.com>

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes

support sofa registry kubernetes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants