-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/threadpool ext #1383
Feat/threadpool ext #1383
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
============================================
- Coverage 72.00% 71.98% -0.02%
- Complexity 784 785 +1
============================================
Files 417 421 +4
Lines 17709 17782 +73
Branches 2760 2770 +10
============================================
+ Hits 12751 12801 +50
- Misses 3553 3566 +13
- Partials 1405 1415 +10 ☔ View full report in Codecov by Sentry. |
core-impl/filter/src/main/java/com/alipay/sofa/rpc/filter/BeanIdMatchFilter.java
Show resolved
Hide resolved
core/api/src/main/java/com/alipay/sofa/rpc/dynamic/DynamicConfigManagerFactory.java
Show resolved
Hide resolved
public ThreadPoolExecutor getExecutor() { | ||
if (executor == null) { | ||
getExecutorService(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是初始化executorService,最终返回的是executor
metrics/metrics-lookout/src/main/java/com/alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java
Show resolved
Hide resolved
core/api/src/main/java/com/alipay/sofa/rpc/common/threadpool/ThreadPoolConstant.java
Outdated
Show resolved
Hide resolved
remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServer.java
Outdated
Show resolved
Hide resolved
remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServer.java
Outdated
Show resolved
Hide resolved
remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation:
Modification:
Describe the idea and modifications you've done.
Result: