Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/threadpool ext #1383

Merged
merged 23 commits into from
Jan 9, 2024
Merged

Feat/threadpool ext #1383

merged 23 commits into from
Jan 9, 2024

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Dec 22, 2023

Motivation:

  • support thread pool extension
  • support virtual thread under jdk 21

Modification:

Describe the idea and modifications you've done.

Result:

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/L labels Dec 22, 2023
@Lo1nt Lo1nt added this to the 5.12.0 milestone Dec 26, 2023
@sofastack-cla sofastack-cla bot added size/XL and removed size/L labels Jan 2, 2024
@Lo1nt Lo1nt requested a review from EvenLjj January 2, 2024 06:22
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (42d19b1) 72.00% compared to head (c6019d2) 71.98%.
Report is 1 commits behind head on master.

Files Patch % Lines
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 53.06% 16 Missing and 7 partials ⚠️
.../sofa/rpc/dynamic/DynamicConfigManagerFactory.java 0.00% 6 Missing ⚠️
...ava/com/alipay/sofa/rpc/server/UserThreadPool.java 75.00% 2 Missing and 2 partials ⚠️
...sofa/rpc/common/threadpool/ThreadPoolConstant.java 0.00% 1 Missing ⚠️
...threadpool/extension/VirtualThreadPoolFactory.java 50.00% 1 Missing ⚠️
.../alipay/sofa/rpc/server/UserVirtualThreadPool.java 83.33% 1 Missing ⚠️
...a/com/alipay/sofa/rpc/event/LookoutSubscriber.java 66.66% 0 Missing and 1 partial ⚠️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1383      +/-   ##
============================================
- Coverage     72.00%   71.98%   -0.02%     
- Complexity      784      785       +1     
============================================
  Files           417      421       +4     
  Lines         17709    17782      +73     
  Branches       2760     2770      +10     
============================================
+ Hits          12751    12801      +50     
- Misses         3553     3566      +13     
- Partials       1405     1415      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lo1nt Lo1nt marked this pull request as ready for review January 4, 2024 11:10
public ThreadPoolExecutor getExecutor() {
if (executor == null) {
getExecutorService();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是初始化executorService,最终返回的是executor

@Lo1nt Lo1nt requested a review from EvenLjj January 8, 2024 09:43
@EvenLjj EvenLjj mentioned this pull request Jan 9, 2024
@EvenLjj EvenLjj linked an issue Jan 9, 2024 that may be closed by this pull request
@chuailiwu chuailiwu self-requested a review January 9, 2024 12:22
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lo1nt Lo1nt merged commit bd25a4e into sofastack:master Jan 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add theadpool extension
3 participants