Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test unstable problem #1355

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Jul 26, 2023

Sometimes localhost will resolve to an IPv6 address.

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes CLA is ok size/M labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1355 (c92ebc5) into master (3c750e4) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1355      +/-   ##
============================================
- Coverage     72.10%   72.07%   -0.03%     
- Complexity      783      784       +1     
============================================
  Files           416      416              
  Lines         17661    17661              
  Branches       2752     2752              
============================================
- Hits          12735    12730       -5     
- Misses         3523     3525       +2     
- Partials       1403     1406       +3     

see 2 files with indirect coverage changes

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj added this to the 5.11.0 milestone Jul 28, 2023
@EvenLjj EvenLjj merged commit 8ca4f28 into sofastack:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants